Skip to content

Conversation

@peachisai
Copy link
Contributor

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#.
  • Update the CHANGES log.

@wu-sheng wu-sheng requested a review from Copilot January 25, 2026 08:28
@wu-sheng wu-sheng added this to the 0.10.0 milestone Jan 25, 2026
@wu-sheng wu-sheng added the bug Something isn't working label Jan 25, 2026
@wu-sheng wu-sheng requested a review from hanahmily January 25, 2026 08:29
@wu-sheng
Copy link
Member

Please update changes if this bug exists from 0.9.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the version handling when merging top N results in BanyanDB's measure query logic.

Changes:

  • Refactored hardcoded schema name to use constant for better maintainability
  • Fixed version update logic to execute outside the field columns loop, ensuring proper version tracking

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
banyand/measure/query.go Replaced hardcoded string "_top_n_result" with TopNSchemaName constant
banyand/measure/block.go Moved version update logic outside the for loop to ensure it executes once per merge operation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.17%. Comparing base (3530dd9) to head (4f90e91).
⚠️ Report is 122 commits behind head on main.

Files with missing lines Patch % Lines
banyand/measure/query.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   45.97%   47.17%   +1.19%     
==========================================
  Files         328      384      +56     
  Lines       55505    59626    +4121     
==========================================
+ Hits        25520    28128    +2608     
- Misses      27909    28867     +958     
- Partials     2076     2631     +555     
Flag Coverage Δ
banyand 49.62% <50.00%> (?)
bydbctl 81.91% <ø> (?)
fodc 78.68% <ø> (?)
integration-distributed 80.00% <ø> (?)
pkg 29.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peachisai
Copy link
Contributor Author

peachisai commented Jan 25, 2026

Please update changes if this bug exists from 0.9.

Actually not ,it is related to #937

@wu-sheng wu-sheng merged commit 208982a into apache:main Jan 25, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants