-
Notifications
You must be signed in to change notification settings - Fork 105
Fix the latest version when merging top n results #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the latest version when merging top n results #958
Conversation
|
Please update changes if this bug exists from 0.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes a bug in the version handling when merging top N results in BanyanDB's measure query logic.
Changes:
- Refactored hardcoded schema name to use constant for better maintainability
- Fixed version update logic to execute outside the field columns loop, ensuring proper version tracking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| banyand/measure/query.go | Replaced hardcoded string "_top_n_result" with TopNSchemaName constant |
| banyand/measure/block.go | Moved version update logic outside the for loop to ensure it executes once per merge operation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
==========================================
+ Coverage 45.97% 47.17% +1.19%
==========================================
Files 328 384 +56
Lines 55505 59626 +4121
==========================================
+ Hits 25520 28128 +2608
- Misses 27909 28867 +958
- Partials 2076 2631 +555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Actually not ,it is related to #937 |
CHANGESlog.