Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 14, 2025

Description

Add Bazel build validation to CI workflow.
Also pin other github actions with their versions documented in a comment

@mmorel-35 mmorel-35 force-pushed the github-workflow branch 3 times, most recently from 47ac993 to aee7476 Compare December 14, 2025 21:40
@mmorel-35 mmorel-35 changed the title Add Bazel build and test validation to CI workflow Add Bazel build validation to CI workflow Dec 14, 2025
@wu-sheng
Copy link
Member

The action bazel-contrib/setup-bazel@4fd964a is not allowed in apache/skywalking-data-collect-protocol

Note this. ASF has a version approval mechanism. You can't use a random version in ASF CI.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Dec 15, 2025

Is there a validation process for bazel-contrib/setup-bazel action ? Or do you prefer a scripted installation for bazel ?

The use of the sha is a security recommend'ation provided by OSSF. Usually it is taken from the release page see for example in
bazel-contrib/[email protected] , the same logic is applied for other actions

@wu-sheng
Copy link
Member

I didn't know this part. But in ASF Infra, it has an approval scope of actions. @kezhenxu94 Do you know where we could check for that list?

@kezhenxu94
Copy link
Member

https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml here is the source of truth for allowed GHA

@mmorel-35
Copy link
Contributor Author

Thanks, I created apache/infrastructure-actions#419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants