Skip to content

Conversation

@CodePrometheus
Copy link
Contributor

@CodePrometheus CodePrometheus commented Feb 25, 2025

test1

@CodePrometheus CodePrometheus marked this pull request as draft February 25, 2025 14:57
@wu-sheng
Copy link
Member

FYI, we plan to release 10.2 in two weeks, waiting for the banyandb 0.8 ready. So, if you want 10.2 including this, let me know.

@CodePrometheus CodePrometheus marked this pull request as ready for review February 27, 2025 04:23
@CodePrometheus CodePrometheus added the enhancement New feature or request label Feb 27, 2025
@CodePrometheus CodePrometheus added this to the 0.6.0 milestone Feb 27, 2025
Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have ability to disabled the so11y? If user wants more good performance, they can disable it.

@CodePrometheus
Copy link
Contributor Author

Do we have ability to disabled the so11y? If user wants more good performance, they can disable it.

Perhaps we can add a global switch to control whether the agent reports metrics, or just control so11y this time? If we want to control so11y, should we completely ban so11y-related collection?

@wu-sheng
Copy link
Member

Is Java agent providing this disable feature?

@CodePrometheus
Copy link
Contributor Author

Is Java agent providing this disable feature?

No, javaagent only uses Config.Meter.ACTIVE to control whether metrics are reported to the OAP, but the collection process continues to run.

@wu-sheng
Copy link
Member

Then I think we should be good for now. @mrproliu Is there any code impacting the performance/throughput significantly?

@mrproliu
Copy link
Contributor

Then I think we should be good for now. @mrproliu Is there any code impacting the performance/throughput significantly?

Currently, the main finding is that some of the data may be inaccurate (asynchronous registration), but this can be fixed at the code level.

@CodePrometheus CodePrometheus requested a review from mrproliu March 1, 2025 06:31
Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After update the multi go version check in plugin test, its looks good to me.

@mrproliu mrproliu merged commit 154de50 into apache:main Mar 1, 2025
38 checks passed
@CodePrometheus CodePrometheus deleted the add-self-so11y branch March 1, 2025 08:48
@wu-sheng
Copy link
Member

wu-sheng commented Mar 1, 2025

@CodePrometheus When you submit PR for the backend, please make sure e2e added and document 0.6 go-agent required.

@CodePrometheus
Copy link
Contributor Author

@CodePrometheus When you submit PR for the backend, please make sure e2e added and document 0.6 go-agent required.

OK, I'll submit it in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants