-
Notifications
You must be signed in to change notification settings - Fork 107
Add agent self-observability #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI, we plan to release 10.2 in two weeks, waiting for the banyandb 0.8 ready. So, if you want 10.2 including this, let me know. |
a0780d0 to
7570623
Compare
mrproliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have ability to disabled the so11y? If user wants more good performance, they can disable it.
Perhaps we can add a global switch to control whether the agent reports metrics, or just control so11y this time? If we want to control so11y, should we completely ban so11y-related collection? |
|
Is Java agent providing this |
No, javaagent only uses |
|
Then I think we should be good for now. @mrproliu Is there any code impacting the performance/throughput significantly? |
Currently, the main finding is that some of the data may be inaccurate (asynchronous registration), but this can be fixed at the code level. |
mrproliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After update the multi go version check in plugin test, its looks good to me.
|
@CodePrometheus When you submit PR for the backend, please make sure e2e added and document 0.6 go-agent required. |
OK, I'll submit it in the coming days. |
Uh oh!
There was an error while loading. Please reload this page.