Remove eck-operator hard dependency for non-ES storage backends#181
Merged
Remove eck-operator hard dependency for non-ES storage backends#181
Conversation
The eck-operator was always installed regardless of the chosen storage backend because it had an independent `eckOperator.enabled` condition that defaulted to true. This change removes the standalone flag and ties the operator's condition to `elasticsearch.enabled`, so it is only deployed when Elasticsearch is actually in use.
Apache enforces an allow list for third-party GitHub Actions. Pin docker/login-action to the approved v4.0.0 SHA in both e2e and publish workflows.
The ECK operator deploys CRDs via templates (not the crds/ folder), so a single helm install fails because the Elasticsearch CR is submitted before the CRD exists. Restore the separate ECK operator install step and use eck-operator subchart values to skip its duplicate deployment in the main chart install.
Install only the eck-operator-crds subchart first to register the Elasticsearch CRD, then install the full SkyWalking chart (including the ECK operator) with installCRDs=false to avoid duplicate CRDs. This avoids both the CRD-not-found error and the Helm release ownership conflict.
The ECK Elasticsearch CRDs must exist before helm install because Helm validates custom resources against the API server. Update docs with the CRD pre-install step and rename e2e step back to Install ECK operator.
wu-sheng
changed the title
kezhenxu94
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eckOperator.enabledflag. The eck-operator chart dependency now shares theelasticsearch.enabledcondition, so it is only deployed when Elasticsearch is in use.elasticsearch.enabled=falseis sufficient.docker/login-actionto the Apache-approved SHA (v4.0.0) in CI workflows.Test plan
helm templatewithelasticsearch.enabled=falseproduces zero eck-operator resourceshelm templatewithelasticsearch.enabled=trueincludes eck-operator resourceseck-operator.installCRDs=false