Skip to content

fix: pin packaging dep to 25 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 4 commits into from
Jan 12, 2026
Merged

fix: pin packaging dep to 25 #383

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9640c59
fix: pin packaging dep to 25
kezhenxu94 Jan 12, 2026
4358780
Update Kafka image to use bitnamilegacy version
kezhenxu94 Jan 12, 2026
92164fc
Update pyproject.toml
kezhenxu94 Jan 12, 2026
2501aec
Update docker-compose.yml
kezhenxu94 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ sw-python = 'skywalking.bootstrap.cli.sw_python:start'
python = ">=3.8, <=3.13"
grpcio = '*'
grpcio-tools = '*'
packaging = '*'
packaging = '25.0'
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description lacks critical information about why the packaging dependency needs to be pinned to version 25.0. Without context about what issue this fixes or why this specific version is required, it's difficult to validate whether this is the correct approach.

Additionally, the poetry.lock file currently shows packaging version 24.2 is in use. If version 25.0 doesn't exist yet or if there are compatibility concerns, this change could break the build. Please verify that:

  1. Version 25.0 of the packaging library actually exists and is available on PyPI
  2. It's compatible with the Python version constraints (>=3.8, <=3.13)
  3. There's a documented reason for this specific version pin (e.g., a bug fix, breaking change in a newer version, etc.)
Suggested change
packaging = '25.0'
packaging = '24.2'

Copilot uses AI. Check for mistakes.
wrapt = '*'
psutil = '<=5.9.5'
requests = { version = ">=2.26.0", optional = true }
Expand Down
Loading