Including the original OAP config into profile exporter tool#13101
Merged
wu-sheng merged 8 commits intoapache:masterfrom Mar 14, 2025
Merged
Including the original OAP config into profile exporter tool#13101wu-sheng merged 8 commits intoapache:masterfrom
wu-sheng merged 8 commits intoapache:masterfrom
Conversation
Member
|
Could you add an e2e to this to avoid breaking? We usually forgot to upgrade this when adding new internal services. |
Contributor
Author
|
Sure, I'll update this PR and add some cases about this. |
wu-sheng
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the profile exporter, It will only include self-configuration. But since the banyanDB is ready to separate a new configuration file, the profile exporter should include the original config path to fix it.
CHANGESlog.