Add JSON format support for the /debugging/config/dump status API
#13263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
added
backend
wankai123
previously approved these changes
May 26, 2025
kezhenxu94
reviewed
May 26, 2025
| public String dumpConfigurations() { | ||
| return serverStatusService.dumpBootingConfigurations(config.getKeywords4MaskingSecretsOfConfig()); | ||
| public String dumpConfigurations(HttpRequest request) { | ||
| if ("application/json".equalsIgnoreCase(request.headers().get(HttpHeaderNames.ACCEPT))) { |
Member
There was a problem hiding this comment.
This is fragile, some tools/browsers/sdks might send Accept header like this Accept: application/json; charset=utf-8
Member
Author
There was a problem hiding this comment.
Updated here and similar codes in TTL status APIs
Fine0830
approved these changes
May 26, 2025
kezhenxu94
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.