Skip to content

Fix disable.oal does not work. #13290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 1 commit into from
Jun 3, 2025
Merged

Fix disable.oal does not work. #13290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/en/changes/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
* Refactor: simplify the `Accept` http header process.
* [Break Change]Storage: Move `event` from metrics to recods.
* Remove string limitation in Jackson deserializer for ElasticSearch client.
* Fix `disable.oal` does not work.

#### UI

Expand Down
6 changes: 3 additions & 3 deletions ...r/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,16 +405,16 @@ public void start() throws ModuleStartException {
moduleConfig.getMaxHttpUrisNumberPerService()
);

// Disable OAL script has higher priority
oalEngineLoaderService.load(DisableOALDefine.INSTANCE);

try {
receiver.scan();
annotationScan.scan();
} catch (IOException | IllegalAccessException | InstantiationException | StorageException e) {
throw new ModuleStartException(e.getMessage(), e);
}

// Disable OAL script has higher priority
oalEngineLoaderService.load(DisableOALDefine.INSTANCE);

Address gRPCServerInstanceAddress = new Address(moduleConfig.getGRPCHost(), moduleConfig.getGRPCPort(), true);
TelemetryRelatedContext.INSTANCE.setId(gRPCServerInstanceAddress.toString());
ClusterCoordinator coordinator = this.getManager()
Expand Down
Loading