Tracing Query Execution HTTP APIs: make the argument service layer optional.#13382
Merged
wankai123 merged 1 commit intoapache:masterfrom Jul 24, 2025
Merged
Tracing Query Execution HTTP APIs: make the argument service layer optional.#13382wankai123 merged 1 commit intoapache:masterfrom
service layer optional.#13382wankai123 merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR makes the serviceLayer parameter optional in Tracing Query Execution HTTP APIs by updating method signatures to accept Optional<String> instead of String and providing a default value of true for the isNormal flag when the parameter is not provided.
- Changed parameter type from
StringtoOptional<String>for various debugging HTTP endpoints - Updated logic to default to
isNormal=truewhenserviceLayeris not provided - Updated documentation to reflect the optional nature of the parameter and removed it from example URLs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| DebuggingHTTPHandler.java | Updated method signatures to make serviceLayer optional and added default handling logic |
| query-tracing.md | Updated documentation to mark serviceLayer parameters as optional and removed from examples |
| changes.md | Added changelog entry for the feature |
...s-query-plugin/src/main/java/org/apache/skywalking/oap/query/debug/DebuggingHTTPHandler.java
Show resolved
Hide resolved
...s-query-plugin/src/main/java/org/apache/skywalking/oap/query/debug/DebuggingHTTPHandler.java
Show resolved
Hide resolved
...s-query-plugin/src/main/java/org/apache/skywalking/oap/query/debug/DebuggingHTTPHandler.java
Show resolved
Hide resolved
wu-sheng
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.