GraphQL API: metadata, topology, log and trace support query by name.#13388
Merged
wu-sheng merged 5 commits intoapache:masterfrom Jul 29, 2025
Merged
GraphQL API: metadata, topology, log and trace support query by name.#13388wu-sheng merged 5 commits intoapache:masterfrom
wu-sheng merged 5 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds GraphQL API support for querying metadata, topology, logs, and traces using human-readable names instead of internal IDs. The implementation introduces new condition classes that accept service names, instance names, and endpoint names with optional layer information to generate appropriate IDs internally.
Key changes:
- New query methods that accept name-based conditions for all major GraphQL query types
- Introduction of ServiceCondition, InstanceCondition, and EndpointCondition classes for ID generation
- Service ID validation in topology queries to filter out non-existent services
- Updated GraphQL schema documentation to reflect the new query methods
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| query-protocol | Updates subproject commit reference |
| TraceQuery.java | Adds queryBasicTracesByName method with TraceQueryConditionByName parameter |
| TopologyQuery.java | Adds topology query methods that accept name-based conditions |
| MetadataQueryV2.java | Adds metadata query methods supporting ServiceCondition parameter |
| LogQuery.java | Adds queryLogsByName method with LogQueryConditionByName parameter |
| TraceQueryConditionByName.java | New condition class for trace queries using names |
| ServiceCondition.java | New condition class for service identification by name and layer |
| LogQueryConditionByName.java | New condition class for log queries using names |
| InstanceCondition.java | New condition class for instance identification by name |
| EndpointCondition.java | New condition class for endpoint identification by name |
| TopologyQueryService.java | Adds service existence validation and removes IOException from getService |
| MetadataQueryService.java | Removes IOException from getService method signature |
| query-tracing.md | Updates documentation with new GraphQL query methods |
| changes.md | Adds changelog entry for the feature |
| query-protocol.md | Updates API documentation with new query methods |
...hql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/TopologyQuery.java
Outdated
Show resolved
Hide resolved
...ver-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyQueryService.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Jul 29, 2025
...ver-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyQueryService.java
Outdated
Show resolved
Hide resolved
wu-sheng
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalstatus flag as service ID alternative in GraphQL #12761.CHANGESlog.