Skip to content

Conversation

@wankai123
Copy link
Member

And also include the following changes:

  • BanyanDB: remove @StoreIDAsTag, and automatically create a virtual String tag id for the SeriesID in IndexMode.

  • Remove method appendMutant from StorageID.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.

  • Update the CHANGES log.

…`IndexMode`.

BanyanDB: remove `@StoreIDAsTag`, and automatically create a virtual String tag `id` for the SeriesID in `IndexMode`.
Remove method `appendMutant` from StorageID.
@wankai123 wankai123 added this to the 10.3.0 milestone Sep 4, 2025
@wankai123 wankai123 added the bug Something isn't working and you are sure it's a bug! label Sep 4, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the BanyanDBMetricsDAO.multiGet method not working properly in IndexMode and removes the @StoreIDAsTag annotation in favor of automatically creating a virtual String tag id for the SeriesID in IndexMode.

  • Removes @StoreIDAsTag annotation and related functionality
  • Automatically adds virtual id tag for IndexMode metrics
  • Simplifies StorageID by removing appendMutant methods and associated complexity

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
JDBCTableInstaller.java Changes import from Metrics.ID to StorageData.ID
BanyanDBMetricsDAO.java Fixes multiGet method for IndexMode and uses StorageData.ID constant
BanyanDBMetadataQueryDAO.java Updates to use StorageData.ID constant
MetadataRegistry.java Adds automatic ID tag creation for IndexMode and removes StoreIDAsTag logic
BanyanDBConverter.java Removes ID constant definition in favor of StorageData.ID
StorageModels.java Removes StoreIDAsTag annotation processing
BanyanDBModelExtension.java Removes storeIDTag field and updates documentation
BanyanDB.java Removes StoreIDAsTag annotation and updates IndexMode documentation
StorageID.java Removes appendMutant methods and simplifies Fragment structure
StorageData.java Adds ID constant definition
Multiple traffic/record classes Updates to use simplified StorageID append methods
changes.md Documents the changes made

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

wu-sheng
wu-sheng previously approved these changes Sep 4, 2025
@wu-sheng wu-sheng merged commit 443157b into apache:master Sep 4, 2025
342 of 345 checks passed
@wu-sheng wu-sheng added the backend OAP backend related. label Sep 4, 2025
@wankai123 wankai123 deleted the banyandb-mget branch September 4, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants