Skip to content

Comments

BanyanDB: fix when setting @BanyanDB.TimestampColumn, the column should not be indexed.#13525

Merged
wu-sheng merged 4 commits intoapache:masterfrom
wankai123:banyandb-no-index
Sep 28, 2025
Merged

BanyanDB: fix when setting @BanyanDB.TimestampColumn, the column should not be indexed.#13525
wu-sheng merged 4 commits intoapache:masterfrom
wankai123:banyandb-no-index

Conversation

@wankai123
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wankai123 wankai123 added this to the 10.3.0 milestone Sep 28, 2025
@wankai123 wankai123 added bug Something isn't working and you are sure it's a bug! backend OAP backend related. labels Sep 28, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a BanyanDB indexing issue where columns marked with @BanyanDB.TimestampColumn should not be indexed. The fix ensures that timestamp columns are properly excluded from index creation in BanyanDB while removing redundant @BanyanDB.NoIndexing annotations.

  • Updated MetadataRegistry to check if timestamp columns should be indexed before creating index rules
  • Removed @BanyanDB.NoIndexing annotations from timestamp fields across multiple record classes
  • Fixed error messages and improved documentation for timestamp column behavior

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
MetadataRegistry.java Added logic to prevent indexing timestamp columns in trace and measure models
StorageModels.java Fixed error message typo for missing TraceIdColumn annotation
Multiple Record classes Removed redundant @BanyanDB.NoIndexing annotations from timestamp fields
BanyanDB.java Updated documentation to clarify timestamp column indexing behavior
ModelColumn.java Added documentation note about BanyanDB extension usage
changes.md Added changelog entry for the fix
query-protocol.md Updated trace query API documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

wankai123 and others added 3 commits September 28, 2025 15:47
…ain/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/server/core/storage/model/StorageModels.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wu-sheng wu-sheng merged commit edd3a26 into apache:master Sep 28, 2025
172 of 173 checks passed
@wankai123 wankai123 deleted the banyandb-no-index branch September 28, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants