BanyanDB: fix when setting @BanyanDB.TimestampColumn, the column should not be indexed.#13525
Merged
wu-sheng merged 4 commits intoapache:masterfrom Sep 28, 2025
Merged
Conversation
…ould not be indexed.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a BanyanDB indexing issue where columns marked with @BanyanDB.TimestampColumn should not be indexed. The fix ensures that timestamp columns are properly excluded from index creation in BanyanDB while removing redundant @BanyanDB.NoIndexing annotations.
- Updated MetadataRegistry to check if timestamp columns should be indexed before creating index rules
- Removed
@BanyanDB.NoIndexingannotations from timestamp fields across multiple record classes - Fixed error messages and improved documentation for timestamp column behavior
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MetadataRegistry.java | Added logic to prevent indexing timestamp columns in trace and measure models |
| StorageModels.java | Fixed error message typo for missing TraceIdColumn annotation |
| Multiple Record classes | Removed redundant @BanyanDB.NoIndexing annotations from timestamp fields |
| BanyanDB.java | Updated documentation to clarify timestamp column indexing behavior |
| ModelColumn.java | Added documentation note about BanyanDB extension usage |
| changes.md | Added changelog entry for the fix |
| query-protocol.md | Updated trace query API documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java
Outdated
Show resolved
Hide resolved
...er-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
Outdated
Show resolved
Hide resolved
…ain/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/server/core/storage/model/StorageModels.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wu-sheng
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.