BrowserErrorLog, OAP Server generated UUID to replace the original client side ID#13659
Merged
wu-sheng merged 8 commits intoapache:masterfrom Jan 14, 2026
Merged
BrowserErrorLog, OAP Server generated UUID to replace the original client side ID#13659wu-sheng merged 8 commits intoapache:masterfrom
BrowserErrorLog, OAP Server generated UUID to replace the original client side ID#13659wu-sheng merged 8 commits intoapache:masterfrom
Conversation
Fine0830
previously approved these changes
Jan 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses the issue of non-unique IDs generated by browser scripts by having the OAP Server generate UUIDs server-side instead of relying on client-side generated IDs for BrowserErrorLog entries.
Changes:
- Modified
BrowserErrorLogDecorator.getUniqueId()to generate a server-side UUID instead of using the client-provided ID - Updated the CHANGES.md documentation to reflect this modification
- Updated the apm-network subproject commit reference
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| BrowserErrorLogDecorator.java | Replaced client-side ID retrieval with server-side UUID generation to ensure global uniqueness |
| changes.md | Added changelog entry documenting the UUID generation change and fixed a missing period |
| apm-network/src/main/proto | Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...kywalking/oap/server/receiver/browser/provider/parser/errorlog/BrowserErrorLogDecorator.java
Show resolved
Hide resolved
...kywalking/oap/server/receiver/browser/provider/parser/errorlog/BrowserErrorLogDecorator.java
Show resolved
Hide resolved
wu-sheng
previously approved these changes
Jan 13, 2026
wu-sheng
previously approved these changes
Jan 14, 2026
wu-sheng
approved these changes
Jan 14, 2026
wu-sheng
approved these changes
Jan 14, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.