Reformat gradle files with IntelliJ / .editorconfig #4037
+1,881
−1,719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Contributor
Author
|
Unlike #4037 , there is no cost/time overhead (very high for "greclipse" !) or build complexity (however small) to maintain. True that there will be some inconsistency but we have a .editorconfig which should reduce that, especially amongst IntelliJ users. This is an improvement! |
dsmiley
commented
Jan 9, 2026
| def resolved = configurations.javadocs.resolvedConfiguration | ||
| resolved.resolvedArtifacts.each { artifact -> | ||
| resolved.resolvedArtifacts.each {artifact | ||
| -> |
Contributor
Author
There was a problem hiding this comment.
don't love this newline left of the arrow; rather inconsistent. I fiddled with it now and it's appears to be because there are lines below that exceed 100 chars. Tweaks to them result in keeping the newline as it's been, which is nicer. I'll push a fix.
by reflowing to the 100 char width budget. Also removed a couple cases where we didn't need to pass an arg to the lambda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I told IntelliJ to reformat all gradle files. It uses the rules in our
.editorconfig.Also did a little hand-editing.
Once this is merged, I will record the commit in
.git-blame-ignore-revswith a changelog entry with the title:Reformat gradle files with IntelliJ / .editorconfig