SOLR-18144: fix schema designer to auto-create .system in 9x#4202
Merged
dsmiley merged 1 commit intoapache:branch_9xfrom Mar 12, 2026
Merged
SOLR-18144: fix schema designer to auto-create .system in 9x#4202dsmiley merged 1 commit intoapache:branch_9xfrom
dsmiley merged 1 commit intoapache:branch_9xfrom
Conversation
The .system collection is only auto-created in specific circumstances. Those circumstances changed in 9.x.
dsmiley
commented
Mar 10, 2026
| } | ||
|
|
||
| /** Creates the .system collection if it doesn't exist. Returns true iff this created it. */ | ||
| public boolean createSystemColl() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
moved from HttpSolrCall to a more suitable place as the same logic now has 2 callers
| } | ||
| } | ||
|
|
||
| private String getBaseUrl(final String collection) { |
| } | ||
|
|
||
| protected CloudSolrClient cloudClient() { | ||
| // create the system collection if it doesn't exist |
Contributor
Author
There was a problem hiding this comment.
doing this here means pretty minimal change to this class
| configureCluster(1) | ||
| .addConfig(DEFAULT_CONFIGSET_NAME, new File(ExternalPaths.DEFAULT_CONFIGSET).toPath()) | ||
| .configure(); | ||
| // SchemaDesignerConfigSetHelper depends on the blob store |
Contributor
Author
There was a problem hiding this comment.
yay; it's tested now.
Contributor
|
This test is consistently failing for me on the 9x branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18144
This is actually pretty close to Jan/Eric's first attempt. But the creation is centralized to one new method on ZkController. And the test was updated to show that it can pass without pre-creating the .system collection.
I was about to go with the HTTP path I suggested... but it was gnawing at me that a CloudSolrClient really should be fine/ideal if we can just ensure that .system exists.