[SPARK-52059] Fix DataFrame to use SparkSession's transportSecurity
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
May 9, 2025
| transport: .http2NIOPosix( | ||
| target: .dns(host: spark.client.host, port: spark.client.port), | ||
| transportSecurity: .plaintext | ||
| transportSecurity: spark.client.transportSecurity |
There was a problem hiding this comment.
The fix looks good. How does it test? Manually?
viirya
approved these changes
May 9, 2025
|
Actually, the setup is not easy. I believe the only way is to test against the commercial vendor's TLS-enabled Spark Connect Server. I tried to launch and use Databricks Community Edition, but I couldn't find a way to get Spark Connect endpoint there. |
|
BTW, thank you, @viirya ! |
|
Merge to main~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
DataFrameto useSparkSession'stransportSecurity.Why are the changes needed?
To support TLS correctly. This issue was reported during
v0.1.0 RC1vote.Does this PR introduce any user-facing change?
Yes, but it's a bug fix which the previous behavior is not proper.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.