Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 12, 2025

What changes were proposed in this pull request?

This PR aims to update Spark Connect-generated Swift source code with Apache Spark 4.0.0-rc5.

Why are the changes needed?

SPARK-51463 added this code with Apache Spark 4.0.0-rc2.

There were some changes so far like the following.

The following is the procedure.

$ git clone -b v4.0.0-rc5 https://github.com/apache/spark.git
$ cd spark/sql/connect/common/src/main/protobuf/
$ protoc --swift_out=. spark/connect/*.proto
$ protoc --grpc-swift_out=. spark/connect/*.proto

// Remove empty GRPC files
$ git grep 'This file contained no services'
spark/connect/catalog.grpc.swift:// This file contained no services.
spark/connect/commands.grpc.swift:// This file contained no services.
spark/connect/common.grpc.swift:// This file contained no services.
spark/connect/example_plugins.grpc.swift:// This file contained no services.
spark/connect/expressions.grpc.swift:// This file contained no services.
spark/connect/ml.grpc.swift:// This file contained no services.
spark/connect/ml_common.grpc.swift:// This file contained no services.
spark/connect/relations.grpc.swift:// This file contained no services.
spark/connect/types.grpc.swift:// This file contained no services.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya .

@dongjoon-hyun
Copy link
Member Author

Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-52083 branch May 12, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants