Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 16, 2025

What changes were proposed in this pull request?

This PR aims to update SparkSQLRepl example to show up to 10k rows.

Why are the changes needed?

Currently, SparkSQLRepl uses the show() with the default parameters. Although we cannot handle large-numbers of rows due to grpc_max_message_size, we had better have more reasonable default value.

spark-sql (default)> SELECT * FROM RANGE(21);
+---+
| id|
+---+
|  0|
|...|
| 19|
+---+
only showing top 20 rows
Time taken: 118 ms

Does this PR introduce any user-facing change?

This is an example.

How was this patch tested?

Manual test.

$ swift run
spark-sql (default)> SELECT * FROM RANGE(10001);
...
only showing top 10000 rows
Time taken: 142 ms

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya and @peter-toth .
Merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants