[SPARK-52317] Identify InvalidTypeException in SparkConnectClient
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @viirya |
viirya
reviewed
May 27, 2025
| return response.ddlParse.parsed | ||
| } catch let error as RPCError where error.code == .internalError { | ||
| switch error.message { | ||
| case let m where m.contains("UNSUPPORTED_DATATYPE") || m.contains("INVALID_IDENTIFIER"): |
There was a problem hiding this comment.
Is INVALID_IDENTIFIER only for invalid type? It sounds like also for any identifier that could be others?
There was a problem hiding this comment.
Oh. This is only for ddlParse. Okay.
There was a problem hiding this comment.
Yes, I'm currently mapping the internal error to SparkConnectError by finding the details.
I can make INVALID_IDENTIFIER to the official one of SparkConnectError when I collect more instances.
viirya
approved these changes
May 27, 2025
|
Thank you, @viirya . Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to identify
InvalidTypeExceptioninSparkConnectClient.Why are the changes needed?
To centralize the
InvalidTypeExceptionhandling into a single place. Previously, three actors do the same error handling logic redundantly.DataFrameDataFrameReaderDataStreamReaderDoes this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.