[SPARK-52373] Add CRC32 struct
#191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Jun 1, 2025
| @Test | ||
| func testLongChecksum() async throws { | ||
| let str = String(repeating: "Apache Spark Connect Client for Swift", count: 1000) | ||
| #expect(CRC32.checksum(string: str, encoding: .ascii) == 1_985_943_888) |
Member
Author
There was a problem hiding this comment.
This is consistent with JDK CRC32.
jshell> var c = new java.util.zip.CRC32();
jshell> c.update("Apache Spark Connect Client for Swift".repeat(1000).getBytes())
jshell> c.getValue()
$9 ==> 1985943888
dongjoon-hyun
commented
Jun 1, 2025
| @Test | ||
| func testChecksum() async throws { | ||
| let str = "Apache Spark Connect Client for Swift" | ||
| #expect(CRC32.checksum(string: str, encoding: .ascii) == 2_736_908_745) |
Member
Author
There was a problem hiding this comment.
This is consistent with JDK CRC32.
jshell> var c = new java.util.zip.CRC32();
jshell> c.update("Apache Spark Connect Client for Swift".getBytes())
jshell> c.getValue()
$3 ==> 2736908745
Member
Author
|
cc @viirya and @peter-toth |
Member
Author
|
I'll merge this to move forward~ |
viirya
reviewed
Jun 1, 2025
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
I don't look into the crc32 code in details. But if it is verified manually, it should be okay
Member
Author
|
Thank you. |
peter-toth
reviewed
Jun 1, 2025
Member
Author
|
Thank you, @peter-toth . Yes, indeed. I expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
CRC32struct.Why are the changes needed?
Apache Spark Connect requires
CRC32checksum to implement APIs likeaddArtifacts.Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by:
Gemini 2.5 Flash. Ask to write ASF-licensed CRC32 Swift code.CRC32.swiftI verified it manually and wrote test suite,
CRC32Tests.swift.