Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 10, 2025

What changes were proposed in this pull request?

This PR aims to support createDataflowGraph API in order to support Declarative Pipelines (SPARK-51727) of Apache Spark 4.1.0-preview1.

Why are the changes needed?

To support the new feature incrementally.

Does this PR introduce any user-facing change?

No, this is a new feature.

How was this patch tested?

Manually run Apache Spark 4.1.0-preview1 RC1 .

$ sbin/start-connect-server.sh

Run the newly added unit test.

Screenshot 2025-07-09 at 19 18 22

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

cc @viirya and @peter-toth

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jul 10, 2025

Could you review this PR, @HyukjinKwon ? I'm catching up the new features of 4.1.0-preview1.

@HyukjinKwon
Copy link
Member

cc @sryza

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon . Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-52742 branch July 10, 2025 02:48
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya .

@sryza
Copy link

sryza commented Jul 10, 2025

@dongjoon-hyun – not directly related to this PR, but wanted to say:

  1. Awesome to see support for declarative pipelines starting to get added to Spark Connect Swift
  2. If you're planning to also add support for DefineFlow, I wanted to give you a heads up that I'm aiming to post an additional change to it before it gets locked in for 4.1. It will likely involve nesting the relation field inside some sort of QueryFunctionResult message. https://issues.apache.org/jira/browse/SPARK-52762 explains the rationale.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jul 10, 2025

No problem at all, @sryza . I fully understand preview semantic. Nothing is final here.

This aims to be technologically ready for the final delivery. :)

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jul 10, 2025

Just FYI, the basic framework was already merged with the first implementation like the following.

This Spark Connect for Swift development is supposed to give an early feedback to the Apache Spark main repository in the time frame of Apache Spark 4.1.0, @sryza .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants