-
Notifications
You must be signed in to change notification settings - Fork 6
[SPARK-52847] Add ConstraintTests
#215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import Testing | ||
|
||
/// A test suite for new syntaxes from SPARK-51207 (SPIP: Constraints in DSv2) | ||
/// For now, only syntax test is here because Apache Spark 4.1 and the corresponding Apache Iceberg is not released yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing parser can parse these syntaxes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for review. Only 4.1.0-preveiw1
support this.
$ swift test --filter ConstraintTests
...
Suite ConstraintTests started.
Test primary_key() started.
Test primary_key() passed after 0.118 seconds.
Test foreign_key() started.
Test foreign_key() passed after 0.059 seconds.
Test unique() started.
Test unique() passed after 0.088 seconds.
Test check() started.
Test check() passed after 0.087 seconds.
Suite ConstraintTests passed after 0.354 seconds.
Test run with 4 tests passed after 0.354 seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, we have CI for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, because you said only syntax test is here because Apache Spark 4.1 is not released yet, it makes me think that prior Apache Spark 4.1 supports only the syntax and Apache Spark 4.1 begins to support the feature fully. 🙂
Thank you, @viirya . For the record,
|
cc @peter-toth , FYI. |
Merged to main. |
What changes were proposed in this pull request?
This PR aims to add
ConstraintTests
.Why are the changes needed?
To be ready for SPARK-51207 (SPIP: Constraints in DSv2) of Apache Spark 4.1.
Does this PR introduce any user-facing change?
No. This is a test suite addition.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.