Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Aug 25, 2025

What changes were proposed in this pull request?

This PR aims to upgrade gRPC Swift NIO Transport to 2.1.0.

Why are the changes needed?

To bring the latest improvements.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review August 26, 2025 02:02
@dongjoon-hyun
Copy link
Member Author

Although integration-test-mac is still flaky, integration-test-token is identical with integration-test-mac except the existence of SPARK_CONNECT_AUTHENTICATE_TOKEN. I'm going to merge this to move forward.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-53371 branch August 26, 2025 02:05
@dongjoon-hyun
Copy link
Member Author

Although all tests (except integration-test-mac) passed on this PR, main branch seems to fail consistently.

Screenshot 2025-08-25 at 21 04 58

@dongjoon-hyun
Copy link
Member Author

Although this code change looks irrelevant to me, I reverted this (via 1116bfa) in order to reduce the investigation scope.

@dongjoon-hyun
Copy link
Member Author

For the record, all integration tests fails at main branch still. I'm checking Today's Runner Image changes.

dongjoon-hyun added a commit that referenced this pull request Aug 26, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `gRPC Swift NIO Transport` to 2.1.0.

### Why are the changes needed?

To bring the latest improvements.
- https://github.com/grpc/grpc-swift-nio-transport/releases/tag/2.1.0
  - grpc/grpc-swift-nio-transport#122
  - grpc/grpc-swift-nio-transport#120
  - grpc/grpc-swift-nio-transport#115

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #218 from dongjoon-hyun/SPARK-53371.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit a94af2e)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant