Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 3, 2025

What changes were proposed in this pull request?

This PR aims to improve merge_spark_pr.py to accept PR numbers as a CLI argument.

Why are the changes needed?

To provide an alternative shortcut.

BEFORE

$ dev/merge_spark_pr.py
git rev-parse --abbrev-ref HEAD
Which pull request would you like to merge? (e.g. 34): 235
=== JIRA SPARK-53467 ===

AFTER (Additional usage)

$  dev/merge_spark_pr.py 235
git rev-parse --abbrev-ref HEAD
Start to merge pull request #235
=== JIRA SPARK-53467 ===

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual test because this is irrelevant to the CI results.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Since this is a script for committers and the same patch exists in the other Spark repository, I'm going to merge this.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-53467 branch September 3, 2025 04:18
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dongjoon-hyun
Copy link
Member Author

Thank you!

Copy link

@peter-toth peter-toth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants