[SPARK-53774] Update Spark Connect-generated Swift code with protocgen-grpc-swift-2 v2.1.1
#249
+347
−1,865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-gen-grpc-swift-2 v2.1.1
dongjoon-hyun
commented
Oct 1, 2025
|
|
||
| /// Batch results of metrics. | ||
| struct ArrowBatch: @unchecked Sendable { | ||
| struct ArrowBatch: Sendable { |
There was a problem hiding this comment.
This will improve the concurrency issue because @unchecked is gone.
|
After this generator-side PR, I'm going to make a |
viirya
approved these changes
Oct 1, 2025
peter-toth
approved these changes
Oct 1, 2025
|
Thank you always, @viirya and @peter-toth . Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to regenerate
Spark Connect-generated Swift source code withprotoc-gen-grpc-swift-2v2.1.1 from apache/spark@c165355. Previously, it was generated by2.0.0from apache/spark@c165355 .Spark Connect-generated Swift source code #205 (2025-06-30)Why are the changes needed?
Without changing the Spark protobuf files, this PR only applies code-generation bug fixes including concurrency patches:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.