[SPARK-51570] Support filter/where for DataFrame
#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-51570
branch
from
6d81f69 to
ef9dea1
Compare
dongjoon-hyun
force-pushed
the
SPARK-51570
branch
from
ef9dea1 to
95caad3
Compare
|
Could you review this PR when you have some time, @peter-toth ? |
|
Sure @dongjoon-hyun, thanks for pinging me. I'm happy to review this PR, but please allow me a day or 2 to set up a swift env and play a bit with this connector. |
|
Thank you so much. No problem at all, @peter-toth . |
|
Do you have a chance to take a look at this, @peter-toth ? |
peter-toth
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Do you have a chance to take a look at this, @peter-toth ?
Yes, actually I have just finished testing this PR.
Sorry for the delay, but I had to update my MacOS to Sequoia and also wanted to look into the connector code and do some testing.
The change looks good.
|
Thank you so much for spending your time to help this, @peter-toth ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 21, 2025
### What changes were proposed in this pull request? This PR aims to add `build-ubuntu-arm` test pipeline. ### Why are the changes needed? `Linux` arm64 architecture becomes public preview as a new GitHub Action runner. We had better utilize this resource in our test infra. - https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Since `setup-swift` GitHub Action doesn't support `ubuntu-24.04-arm` yet, this PR runs the `Swift` docker image on `ubuntu-24.04-arm` GitHub Action runner. - swift-actions/setup-swift#705 `Swift` Docker images support both `AMD64` and `ARM64` architectures. - https://hub.docker.com/layers/library/swift/6.1.0/images/sha256-e0ce72c88f5f446d5e0c149d34c7b6d29a33d6410b228d55b575988f9e02e15a <img width="426" alt="Screenshot 2025-04-21 at 16 59 50" src="https://github.com/user-attachments/assets/b40146de-db98-4a90-9954-2a44439ee9db" /> ### How was this patch tested? After passing the CIs and check the following in the CI logs. ``` Linux 114e749feb29 6.8.0-1021-azure #25-Ubuntu SMP Wed Jan 15 20:23:05 UTC 2025 aarch64 aarch64 aarch64 GNU/Linux ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52 from dongjoon-hyun/SPARK-51782. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims o support
filterandwhereforDataFrame.Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
No, this is a new addition.
How was this patch tested?
Pass the CIs and manual test on MacOS with Apache Spark 4.0.0 RC3.
Was this patch authored or co-authored using generative AI tooling?
No.