[SPARK-51693] Support storageLevel for DataFrame
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Apr 2, 2025
| return self | ||
| } | ||
|
|
||
| var storageLevel: StorageLevel { |
There was a problem hiding this comment.
I wonder why this is var instead of a function? E.g., in Dataset.scala, it is def storageLevel: StorageLevel.
viirya
approved these changes
Apr 2, 2025
|
Thank you, @viirya . Yes, it is not a function in order to follow the style of existing clients like the following. scala> spark.range(1).storageLevel
Using Spark's default log4j profile: org/apache/spark/log4j2-pattern-layout-defaults.properties
res0: org.apache.spark.storage.StorageLevel = StorageLevel(1 replicas)
scala> spark.range(1).storageLevel()
cmd1.sc:1: org.apache.spark.storage.StorageLevel does not take parameters
val res1 = spark.range(1).storageLevel()
^
Compilation Failed$ bin/pyspark --remote sc://localhost:15002
Python 3.9.21 (main, Dec 5 2024, 09:43:42)
[Clang 16.0.0 (clang-1600.0.26.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
/__ / .__/\_,_/_/ /_/\_\ version 4.0.0
/_/
Using Python version 3.9.21 (main, Dec 5 2024 09:43:42)
Client connected to the Spark Connect server at localhost:15002
SparkSession available as 'spark'.
>>> spark.range(1).storageLevel
StorageLevel(False, False, False, False, 1)
>>> spark.range(1).storageLevel()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'StorageLevel' object is not callable |
|
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
DataFrame.storageLevel.Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
No. This is a new addition to the unreleased version.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.