[SPARK-51719] Support table for SparkSession and DataFrameReader
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
table for SparkSession and DataFrametable for SparkSession and DataFrameReader
dongjoon-hyun
force-pushed
the
SPARK-51719
branch
from
695f882 to
2827bd8
Compare
|
Could you review this PR too, @viirya ? |
viirya
reviewed
Apr 6, 2025
| func table() async throws { | ||
| let tableName = UUID().uuidString.replacingOccurrences(of: "-", with: "") | ||
| let spark = try await SparkSession.builder.getOrCreate() | ||
| #expect(try await spark.sql("CREATE TABLE \(tableName) AS VALUES (1), (2)").count() == 0) |
There was a problem hiding this comment.
Is it possible to also test view currently?
There was a problem hiding this comment.
Thank you for review. For views, there are multiple variants like Permanent View, Temporary View, Global Temporary view. So, I postpone the test coverage until now. However, it will be added soon because I'm implementing Catalog, @viirya .
viirya
approved these changes
Apr 6, 2025
|
Merged to main~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
tableAPI forSparkSessionandDataFrameReader.Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
No, this is a new addition to the unreleased version.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.