Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 6, 2025

What changes were proposed in this pull request?

This PR aims to add Catalog actor and support catalog/database APIs. Other APIs (table/function/column) will be added independently as the second part.

Why are the changes needed?

For feature parity.

Does this PR introduce any user-facing change?

No. This is a new addition to the unreleased version.

How was this patch tested?

Pass the CIs and manual test on MacOS environment.

$ swift test --filter CatalogTests
...
􀟈  Test databaseExists() started.
􀟈  Test setCurrentCatalog() started.
􀟈  Test setCurrentDatabase() started.
􀟈  Test getDatabase() started.
􀟈  Test listDatabases() started.
􀟈  Test listCatalogs() started.
􀟈  Test currentDatabase() started.
􀟈  Test currentCatalog() started.
􁁛  Test currentDatabase() passed after 0.061 seconds.
􁁛  Test currentCatalog() passed after 0.061 seconds.
􁁛  Test setCurrentCatalog() passed after 0.067 seconds.
􁁛  Test setCurrentDatabase() passed after 0.071 seconds.
􁁛  Test getDatabase() passed after 0.138 seconds.
􁁛  Test listCatalogs() passed after 0.143 seconds.
􁁛  Test databaseExists() passed after 0.158 seconds.
􁁛  Test listDatabases() passed after 0.188 seconds.
􁁛  Suite CatalogTests passed after 0.189 seconds.
􁁛  Test run with 8 tests passed after 0.189 seconds.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @peter-toth !
Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51730 branch April 7, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants