Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 10, 2025

What changes were proposed in this pull request?

This PR aims to add ErrorUtils and SQLHelper and use it.

Why are the changes needed?

To support a similar developer experience with tryWithSafeFinally, withDatabase, and withTable.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @LuciferYang ?

Copy link

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one minor issue, but the exception handling in the Scala version of tryWithSafeFinally is quite complex. I think we don't need to maintain complete consistency for now.

@dongjoon-hyun
Copy link
Member Author

Thank you, @LuciferYang . Yep, of course. We don't want to have all complete features.

@dongjoon-hyun
Copy link
Member Author

All comments are addressed. Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51759 branch April 10, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants