[SPARK-51857] Support token/userId/userAgent parameters in SparkConnectClient
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-51857
branch
from
f023c23 to
fc9ceff
Compare
viirya
reviewed
Apr 21, 2025
|
|
||
| /// Create a session that uses the specified connection string and userID. | ||
| /// - Parameters: | ||
| /// - connection: a string in a patter, `sc://{host}:{port}` |
There was a problem hiding this comment.
Do we need to specify possible parameters for connection?
There was a problem hiding this comment.
Thank you for review. For that part, I'll document at the final step. Currently, I'm still working on the remaining params like useSsl (security), sessionId (requires reconnection support), grpcMaxMessageSize.
viirya
approved these changes
Apr 21, 2025
|
Merged to main~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
token/userId/userAgentparameters inSparkConnectClient. After this PR,SparkConnectClientunderstands the following parameters in itsremoteargument.Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.