[SPARK-51870] Support SPARK_GENERATE_GOLDEN_FILES in SQLTests
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Apr 23, 2025
| struct SQLTests { | ||
| let fm = FileManager.default | ||
| let path = Bundle.module.path(forResource: "queries", ofType: "")! | ||
| let encoder = JSONEncoder() |
There was a problem hiding this comment.
nit. This was an unused variable.
viirya
approved these changes
Apr 23, 2025
|
Thank you, @viirya . The |
|
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
SPARK_GENERATE_GOLDEN_FILESinSQLTests.Why are the changes needed?
To improve
SQLTests.Does this PR introduce any user-facing change?
No, this is a test-related improvement.
How was this patch tested?
Pass the CIs and manual review.
Was this patch authored or co-authored using generative AI tooling?
No.