[SPARK-51871] Improve SQLTests to check column names
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Apr 23, 2025
| @@ -1 +1,5 @@ | |||
| [col,int,null] | |||
| +--------+---------+-------+ | |||
| |col_name|data_type|comment| | |||
There was a problem hiding this comment.
Column names are checked like this.
dongjoon-hyun
force-pushed
the
SPARK-51871
branch
2 times, most recently
from
f63f451 to
a039461
Compare
|
This PR is ready. |
viirya
approved these changes
May 1, 2025
|
Thank you, @viirya ! Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve
SQLTeststo check column names.Why are the changes needed?
To improve the test coverage.
Does this PR introduce any user-facing change?
No, this is a test-only improvement.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.