Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 12, 2025

What changes were proposed in this pull request?

This PR aims to add RuntimeConf actor.

classDiagram
    class RuntimeConf {
        -client: SparkConnectClient
        +init(client: SparkConnectClient)
        +set(key: String, value: String) void
        +unset(key: String) void
        +get(key: String) String
        +getAll() [String: String]
    }
Loading

Why are the changes needed?

This is required before adding SparkSession.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @yaooqinn ?

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaooqinn
Copy link
Member

By the way, can we unbind the version tracker of this project to the Spark main repo? It might be inconvenient for the RM of v4.1.0 to generate the release note.

FYI,
https://issues.apache.org/jira/projects/SPARK/versions/12354567

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @yaooqinn .

Sure, for now, I didn't change it, but I'm also think to follow spark-kubernetes-operator repository style.

Screenshot 2025-03-11 at 22 50 06

@dongjoon-hyun
Copy link
Member Author

This will have an independent release cadence (and version pattern and tags).

@dongjoon-hyun
Copy link
Member Author

Please wait for a while until I finish the first migration~ 4.1.0 will be replaced properly in a week.

@dongjoon-hyun
Copy link
Member Author

Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51481 branch March 12, 2025 05:53
@dongjoon-hyun
Copy link
Member Author

To @yaooqinn , I applied new version scheme for all.

By the way, can we unbind the version tracker of this project to the Spark main repo? It might be inconvenient for the RM of v4.1.0 to generate the release note.

Screenshot 2025-03-12 at 12 20 00

@yaooqinn
Copy link
Member

Thank you @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants