[SPARK-51520][K8S] Use JRE to reduce size of Docker image #167
Conversation
jacobsalway
changed the title
jacobsalway
force-pushed
the
use-jre-to-reduce-docker-image-size
branch
from
7d0fd3a to
0fea1be
Compare
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for opening a PR, @jacobsalway .
gradle/libs.versions.toml
Outdated
|
|
||
| # Packaging | ||
| shadow-jar-plugin = "8.1.1" | ||
| shadow-jar-plugin = "8.3.6" |
There was a problem hiding this comment.
The orthogonal change should be handled independently because the PR title should be the main scope of the code.
Please remove this part from this PR.
gradle/libs.versions.toml
Outdated
| spotbugs-gradle-plugin = { group = "com.github.spotbugs.snom", name = "spotbugs-gradle-plugin", version.ref = "spotbugs-plugin" } | ||
| spotless-plugin-gradle = { group = "com.diffplug.spotless", name = "spotless-plugin-gradle", version.ref = "spotless-plugin" } | ||
| shadow = { group = "com.github.johnrengelman", name = "shadow", version.ref = "shadow-jar-plugin"} | ||
| shadow = { group = "com.gradleup.shadow", name = "shadow-gradle-plugin", version.ref = "shadow-jar-plugin"} |
spark-operator/build.gradle
Outdated
| * under the License. | ||
| */ | ||
| apply plugin: 'com.github.johnrengelman.shadow' | ||
| apply plugin: 'com.gradleup.shadow' |
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
I left a comment about the orthogonal code change part.
Signed-off-by: Jacob Salway <[email protected]>
jacobsalway
force-pushed
the
use-jre-to-reduce-docker-image-size
branch
from
0fea1be to
54e0fd2
Compare
Thanks for reviewing. I've removed the plugin changes and will raise a separate JIRA/PR for them. |
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. (Pending CIs). Thank you for updating, @jacobsalway .
|
Merged to main. Thank you again, @jacobsalway . I added you to the Apache Spark contributor group and assigned SPARK-51520 to you. Welcome to the Apache Spark community and congratulations for your first commit! |
|
Thanks @dongjoon-hyun, looking forward to hopefully contributing more in the future |
2 participants
What changes were proposed in this pull request?
Why are the changes needed?
The image is currently quite large at ~500 megabytes
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested locally
Was this patch authored or co-authored using generative AI tooling?
No