[SPARK-51577] Make gradle build to automatically append SNAPSHOT suffix to version for non-release builds #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix to version for non-release builds What changes were proposed in this pull request? This PR makes gradle build automatically append -SNAPSHOT suffix to version for non-release builds Why are the changes needed? This would help to reduce one duplicate hard-coded version in gradle scripts, as we already defined version in gradle properties Does this PR introduce any user-facing change? No How was this patch tested? pass the CIs Was this patch authored or co-authored using generative AI tooling? No
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you check the CI failures, @jiangzho ?
Member
|
Gentle ping, @jiangzho . |
dongjoon-hyun
approved these changes
Mar 26, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @jiangzho .
Merged to main.
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Oh, @jiangzho .
Unfortunately, it turns out that this break the Dockerfile build because it always runs without -Prelease=true. Let me revert his.
Member
|
This is reverted via e5e37f3 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes gradle build automatically append
-SNAPSHOTsuffix toversionfor non-release buildsWhy are the changes needed?
This would help to automatically set up builds based on gradle release properties
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the CIs
Was this patch authored or co-authored using generative AI tooling?
No