[SPARK-51770] Set Content-Type headers for Prometheus v3
#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? This PR sets Content-Type header for Prometheus handler to make it compatible with Prometheus v3 ### Why are the changes needed? Prometheus v3 will fail the scrape if the Content-Type header is not present in response and the fallback scrape protocol is not configured. Therefore we'd configure the headers properly. Please also refer https://prometheus.io/docs/prometheus/latest/migration/#scrape-protocols ### Does this PR introduce any user-facing change? No ### How was this patch tested? Tested via CI and local set up for Prometheus v3, via steps: * Deploy Prometheus v3 in k8s cluster, with default configuration (no fallback_scrape_protocol configured) * Deploy Spark Operator in cluster * Prometheus v3 is able to successfully scrape operator metrics ### Was this patch authored or co-authored using generative AI tooling? No
dongjoon-hyun
approved these changes
Apr 12, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @jiangzho .
dongjoon-hyun
changed the title
Content-Type headers for Prometheus v3 compatibility
dongjoon-hyun
changed the title
Content-Type headers for Prometheus v3 compatibilityContent-Type headers for Prometheus v3
Member
|
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR sets Content-Type header for Prometheus handler to make it compatible with Prometheus v3
Why are the changes needed?
Prometheus v3 will fail the scrape if the Content-Type header is not present in response and the fallback scrape protocol is not configured. Therefore we'd configure the headers properly.
Please also refer https://prometheus.io/docs/prometheus/latest/migration/#scrape-protocols
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested via CI and local set up for Prometheus v3, via steps:
Was this patch authored or co-authored using generative AI tooling?
No