Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 13, 2025

What changes were proposed in this pull request?

This PR aims to update the default value of image.repository of Helm Chart to use apache/spark-kubernetes-operator.

Why are the changes needed?

To use the official images in the source code release.

Does this PR introduce any user-facing change?

  1. No behavior change because we don't publish the official Helm Chart yet.
  2. The published snapshot Helm Chart already uses apache/ prefix already.
  3. For the users who use own repositories, the usage is the same where always overrides the previous and new default valuse.

To override single parameters you can use `--set`, for example:
```
helm install --set image.repository=<my_registory>/spark-kubernetes-operator \

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @viirya ?

@dongjoon-hyun
Copy link
Member Author

Thank you! Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-52106 branch May 13, 2025 17:48
dongjoon-hyun added a commit that referenced this pull request May 14, 2025
### What changes were proposed in this pull request?

This PR aims to change `Helm Chart` version from `0.2.0-SNAPSHOT` to `1.0.0-dev` and revise the description as a part of official release of this chart `1.0.0`.

### Why are the changes needed?

Like [Apache Airflow example](https://github.com/apache/airflow/blob/2d56d2626c84089f156a56137647498a6ad2ee7a/chart/Chart.yaml#L20-L24), `Helm Chart` version is independently managed from the application versions (which is Apache Spark K8s Operator).

```yaml
apiVersion: v2
name: airflow
version: 1.17.0-dev
appVersion: 3.0.0
description: The official Helm chart to deploy Apache Airflow, a platform to
  programmatically author, schedule, and monitor workflows
```

As a part of the following series of Helm Chart improvement, I believe we are ready to set `1.0.0` for Helm Chart itself at next release, Apache Spark K8s Operator v0.2.0.
- #190
- #196
- #191
- #194

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs and manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #197 from dongjoon-hyun/SPARK-52133.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants