[SPARK-52173] Fix OwnerReference Patching for Spark Application Driver Resources #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Resources ### What changes were proposed in this pull request? This PR fixes the logic to patch ownerReference on pre-resources for application. It would decorate the proposed spec instead of created resource with generated fields. ### Why are the changes needed? At initialization phase, operator would request pre-resources for driver first, then apply the owner references on these resources with created driver pod uid. The latter patching is currently failing as it's decorating on created resource (which have managed fields set). ``` Message: metadata.managedFields must be nil. ``` > ... when using the Apply operation you cannot define managedFields in the body of the request that you submit. https://kubernetes.io/docs/reference/using-api/server-side-apply/ The patch body shall not include generated `managedFields` . ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests added ### Was this patch authored or co-authored using generative AI tooling? No
dongjoon-hyun
approved these changes
May 16, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @jiangzho .
Merged to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the logic to patch ownerReference on pre-resources for application. It would decorate the proposed spec instead of created resource with generated fields.
Why are the changes needed?
At initialization phase, operator would request pre-resources for driver first, then apply the owner references on these resources with created driver pod uid.
The latter patching is currently failing as it's decorating on created resource (which have managed fields set).
https://kubernetes.io/docs/reference/using-api/server-side-apply/
The patch body shall not include generated
managedFields.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests added
Was this patch authored or co-authored using generative AI tooling?
No