-
Notifications
You must be signed in to change notification settings - Fork 48
[SPARK-52086] Upgrade operator-sdk to 5.1.1
#252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # under the License. | ||
| [versions] | ||
| fabric8 = "7.3.0" | ||
| fabric8 = "7.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making a PR, but please revert this, @csviri . You can do this upgrade independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ur, wait, your PR looks strange. We already have this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, yes, sorry, did this rather hastily. Rebased now.
|
cc @jiangzho , too |
operator-sdk to v5.1
operator-sdk to v5.1operator-sdk to v5.1.1
operator-sdk to v5.1.1operator-sdk to 5.1.1
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your branch and make the CI happy, @csviri .
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
|
Thank you for updating, @csviri . |
|
It seems to fail still. Could you take a look at the failure, @csviri ? |
Sure, will try to take a look this week! thx |
|
Thank you, @csviri . |
|
Thanks @csviri ! Checked the app reconciler part performs functionalities as previously. |
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
|
@dongjoon-hyun @jiangzho The CI should be happy now. There was a real and quite nasty issue with server side apply when adding the finalizer. Will follow up on that in the core framework. But this should be fine on this side. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
What is your JIRA ID, @csviri ? I can assign SPARK-52086 to you. |
|
BTW, I'm preparing |
sure, please do! |
If you don't have JIRA ID, I cannot do. :) |
Ahh sorry, my username is |
|
Thank you. 👍🏻
Welcome to the Apache Spark community again. |
|
FYI, |
What changes were proposed in this pull request?
Change Java Operator SDK version to v5.1
The intention is to keep the functionality the same as the previous version;
Does this PR introduce any user-facing change?
No
How was this patch tested?
Standard CI should test it.
Was this patch authored or co-authored using generative AI tooling?
No