Skip to content

Conversation

@csviri
Copy link
Contributor

@csviri csviri commented Jun 18, 2025

What changes were proposed in this pull request?

Change Java Operator SDK version to v5.1

The intention is to keep the functionality the same as the previous version;

Does this PR introduce any user-facing change?

No

How was this patch tested?

Standard CI should test it.

Was this patch authored or co-authored using generative AI tooling?

No

# under the License.
[versions]
fabric8 = "7.3.0"
fabric8 = "7.3.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR, but please revert this, @csviri . You can do this upgrade independently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, wait, your PR looks strange. We already have this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes, sorry, did this rather hastily. Rebased now.

@dongjoon-hyun
Copy link
Member

cc @jiangzho , too

@dongjoon-hyun dongjoon-hyun changed the title Bump Java Operator SDK to v5.1 [SPARK-52086] Upgrade operator-sdk to v5.1 Jun 18, 2025
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-52086] Upgrade operator-sdk to v5.1 [SPARK-52086] Upgrade operator-sdk to v5.1.1 Jun 18, 2025
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-52086] Upgrade operator-sdk to v5.1.1 [SPARK-52086] Upgrade operator-sdk to 5.1.1 Jun 18, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch and make the CI happy, @csviri .

csviri added 2 commits June 19, 2025 11:13
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@dongjoon-hyun
Copy link
Member

Thank you for updating, @csviri .

@dongjoon-hyun
Copy link
Member

It seems to fail still. Could you take a look at the failure, @csviri ?

@csviri
Copy link
Contributor Author

csviri commented Jun 23, 2025

It seems to fail still. Could you take a look at the failure, @csviri ?

Sure, will try to take a look this week! thx

@dongjoon-hyun
Copy link
Member

Thank you, @csviri .

@jiangzho
Copy link
Contributor

Thanks @csviri !

Checked the app reconciler part performs functionalities as previously.

csviri added 2 commits June 27, 2025 17:20
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
Copy link
Contributor Author

csviri commented Jun 27, 2025

@dongjoon-hyun @jiangzho The CI should be happy now. There was a real and quite nasty issue with server side apply when adding the finalizer. Will follow up on that in the core framework. But this should be fine on this side.
Thank you!

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @csviri and @jiangzho .
Merged to main.

@dongjoon-hyun
Copy link
Member

What is your JIRA ID, @csviri ? I can assign SPARK-52086 to you.

@dongjoon-hyun
Copy link
Member

BTW, I'm preparing v0.4.0 to deliver this, @csviri . The vote will start on July 1st.

@csviri
Copy link
Contributor Author

csviri commented Jun 29, 2025

What is your JIRA ID, @csviri ? I can assign SPARK-52086 to you.

sure, please do!

@dongjoon-hyun
Copy link
Member

What is your JIRA ID, @csviri ? I can assign SPARK-52086 to you.

sure, please do!

If you don't have JIRA ID, I cannot do. :)
May I ask you again what your JIRA ID is, @csviri ?

@csviri
Copy link
Contributor Author

csviri commented Jun 30, 2025

What is your JIRA ID, @csviri ? I can assign SPARK-52086 to you.

sure, please do!

If you don't have JIRA ID, I cannot do. :) May I ask you again what your JIRA ID is, @csviri ?

Ahh sorry, my username is csviri. Full name: Attila Mészáros

@dongjoon-hyun
Copy link
Member

Thank you. 👍🏻

  • I added csviri to the Apache Spark contributor group in JIRA system.
  • Then, assigned SPARK-52086 to you.

Welcome to the Apache Spark community again.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jun 30, 2025

FYI, 0.4.0 RC1 vote started Today including this PR. Please participate if you are interested in, @csviri , @jiangzho , @peter-toth .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants