[SPARK-52559] Synchronize SparkOperatorConfManager.getValue
#256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix a concurrency issue by synchronizing
SparkOperatorConfManager.getValue.Why are the changes needed?
configOverridesis supposed by being protected bythisatrefreshmethod.spark-kubernetes-operator/spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConfManager.java
Lines 71 to 76 in 35214b0
However, currently
getValuecan access an empty value whilerefreshinvokesthis.configOverrides = new Properties();statement becausegetValuemethod is not synchronized properly.spark-kubernetes-operator/spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConfManager.java
Lines 62 to 65 in 35214b0
Does this PR introduce any user-facing change?
Yes, this is a bug fix.
How was this patch tested?
Manual review. (It's a little difficult to add a concurrency failure test case).
Was this patch authored or co-authored using generative AI tooling?
No.