[SPARK-52831] Revise the default logging layout to include only name & namespace MDC Keys #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& namespace MDC Keys
### What changes were proposed in this pull request?
This PR updates the default layout in operator helm chart, to make it include only the resource name and namespace MDC keys instead of all
### Why are the changes needed?
The current logging is extremely verbose by default:
```
25/07/16 22:47:03 INFO {resource.apiVersion=spark.apache.org/v1, resource.app.attemptId=0, resource.generation=2, resource.kind=SparkApplication, resource.name=test-00553, resource.namespace=default, resource.resourceVersion=77206, resource.uid=c8c40a69-7397-4230-8bef-701c25436b54} o.a.s.k.o.r.SparkAppReconciler [ReconcilerExecutor-sparkappreconciler-73] Cleaning up resources for SparkApp:test-00553
25/07/16 22:47:03 INFO {resource.apiVersion=spark.apache.org/v1, resource.app.attemptId=0, resource.generation=2, resource.kind=SparkApplication, resource.name=test-00554, resource.namespace=default, resource.resourceVersion=77208, resource.uid=e007ca5f-94c0-4c30-8e1e-543aafb65c67} o.a.s.k.o.r.SparkAppReconciler [ReconcilerExecutor-sparkappreconciler-52] Cleaning up resources for SparkApp:test-00554
25/07/16 22:47:03 INFO {resource.apiVersion=spark.apache.org/v1, resource.app.attemptId=0, resource.generation=2, resource.kind=SparkApplication, resource.name=test-00555, resource.namespace=default, resource.resourceVersion=77211, resource.uid=7ea87cb4-6dca-43be-be08-ac9dca335912} o.a.s.k.o.r.SparkAppReconciler [ReconcilerExecutor-sparkappreconciler-69] Cleaning up resources for SparkApp:test-00555
```
With this patch, logging would include only resource name and namespace (which are most critical)
```
25/07/16 16:18:35 INFO {resource.name=pi, resource.namespace=default} o.a.s.k.o.r.SparkAppReconciler Cleaning up resources for SparkApp:pi
```
users may still override the values to include more keys as needed. This is to make sure we have informational and concise logging by default.
### Does this PR introduce _any_ user-facing change?
Logging enhancements expected for operator
### How was this patch tested?
CIs for lint, and validated logging in dev environments
### Was this patch authored or co-authored using generative AI tooling?
No
Contributor
Author
|
cc @peter-toth |
dongjoon-hyun
approved these changes
Jul 17, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for quick fix, @jiangzho .
Contributor
|
Late LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the default layout in operator helm chart, to make it include only the resource name and namespace MDC keys instead of all
Why are the changes needed?
The current logging is extremely verbose by default:
With this patch, logging would include only resource name and namespace (which are most critical)
users may still override the values to include more keys as needed. This is to make sure we have informational and concise logging by default.
Does this PR introduce any user-facing change?
Logging enhancements expected for operator
How was this patch tested?
CIs for lint, and validated logging in dev environments
Was this patch authored or co-authored using generative AI tooling?
No