[SPARK-53159] Declare metrics port for operator in helm chart #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? Spark Operator provides prometheus format metrics by default. This PR adds metrics port spec to the operator helm chart. ### Why are the changes needed? Declaring the port in spec for better clarity and maintainability. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CIs, helm lint, and local testing ### Was this patch authored or co-authored using generative AI tooling? No
Contributor
Author
|
cc @peter-toth can you please help to review ? |
peter-toth
reviewed
Aug 7, 2025
| spark.kubernetes.operator.namespace={{ .Release.Namespace }} | ||
| spark.kubernetes.operator.name={{- include "spark-operator.name" . }} | ||
| spark.kubernetes.operator.dynamicConfig.enabled={{ .Values.operatorConfiguration.dynamicConfig.enable }} | ||
| spark.kubernetes.operator.metrics.port={{ include "spark-operator.metricsPort" . }} |
Contributor
There was a problem hiding this comment.
Not related to this PR, but @jiangzho can you please check why spark.kubernetes.operator.health.probePort is not set here from spark-operator.probePort?
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch!
Yes, we'll need to fix that as well when user override the port from Helm chart values. I'll track that over SPARK-53186
Contributor
Author
|
@peter-toth would you mind rerun the failed test suite ? I checked the failure and not able to reproduce, seems a blip |
Contributor
|
Tests passed. Thank you @jiangzho for the fix. Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark Operator provides prometheus format metrics by default. This PR adds metrics port spec to the operator helm chart.
Why are the changes needed?
Declaring the port in spec for better clarity and maintainability.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CIs, helm lint, and local testing
Was this patch authored or co-authored using generative AI tooling?
No