[SPARK-53187]Support SparkCluster event related metrics set #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request?
This PR adds SparkCluster as a supported type in metrics and therefore supports publishing execution metrics for it.
### Why are the changes needed?
Operatoer by default publish metrics by resource type (SparkApplication) - by adding this support, we suppor the same set of counter and histogram for received event and timed execution
### Does this PR introduce _any_ user-facing change?
More Metrics becomes available for SparkClusters
### How was this patch tested?
From dev sandbox we can see metrics like
```
metrics_operator.sdk_sparkapplication_added_resource_event_Count{type="counters"} 9010
metrics_operator.sdk_sparkapplication_reconciliation_failed_Count{type="counters"} 9
metrics_operator.sdk_sparkapplication_reconciliation_finished_Count{type="counters"} 182841
metrics_operator.sdk_sparkapplication_reconciliation_retries_Count{type="counters"} 9
metrics_operator.sdk_sparkcluster_added_resource_event_Count{type="counters"} 9009
metrics_operator.sdk_sparkcluster_reconciliation_failed_Count{type="counters"} 0
metrics_operator.sdk_sparkcluster_reconciliation_finished_Count{type="counters"} 182821
metrics_operator.sdk_sparkcluster_reconciliation_retries_Count{type="counters"} 0
```
### Was this patch authored or co-authored using generative AI tooling?
No
Contributor
Author
|
cc @peter-toth for review. Thanks a lot! |
peter-toth
approved these changes
Aug 8, 2025
Contributor
peter-toth
left a comment
peter-toth
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvement!
Contributor
|
Thanks for the PR @jiangzho! Merged to |
jiangzho
added a commit
to jiangzho/spark-kubernetes-operator
that referenced
this pull request
Aug 8, 2025
### What changes were proposed in this pull request?
This PR adds SparkCluster as a supported type in metrics and therefore supports publishing execution metrics for it.
### Why are the changes needed?
Operator by default publish metrics by resource type (SparkApplication) - by adding this support, we support the same set of counter and histogram for received event and timed execution
### Does this PR introduce _any_ user-facing change?
More Metrics becomes available for SparkClusters
### How was this patch tested?
From dev sandbox we can see metrics like
```
metrics_operator.sdk_sparkapplication_added_resource_event_Count{type="counters"} 9010
metrics_operator.sdk_sparkapplication_reconciliation_failed_Count{type="counters"} 9
metrics_operator.sdk_sparkapplication_reconciliation_finished_Count{type="counters"} 182841
metrics_operator.sdk_sparkapplication_reconciliation_retries_Count{type="counters"} 9
metrics_operator.sdk_sparkcluster_added_resource_event_Count{type="counters"} 9009
metrics_operator.sdk_sparkcluster_reconciliation_failed_Count{type="counters"} 0
metrics_operator.sdk_sparkcluster_reconciliation_finished_Count{type="counters"} 182821
metrics_operator.sdk_sparkcluster_reconciliation_retries_Count{type="counters"} 0
```
### Was this patch authored or co-authored using generative AI tooling?
No
Closes apache#295 from jiangzho/cluster_metrics.
Authored-by: Zhou JIANG <[email protected]>
Signed-off-by: Peter Toth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds SparkCluster as a supported type in metrics and therefore supports publishing execution metrics for it.
Why are the changes needed?
Operator by default publish metrics by resource type (SparkApplication) - by adding this support, we support the same set of counter and histogram for received event and timed execution
Does this PR introduce any user-facing change?
More Metrics becomes available for SparkClusters
How was this patch tested?
From dev sandbox we can see metrics like
Was this patch authored or co-authored using generative AI tooling?
No