Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 17, 2025

What changes were proposed in this pull request?

This PR aims to upgrade pmd and spotbugs test dependency and enable it on Java 25.

Why are the changes needed?

Previously, PMD and SpotBugs check are enabled only on Java 17 and 21.

Does this PR introduce any user-facing change?

No behavior change because this is a code quality check during building.

How was this patch tested?

Pass the CIs. Java 25 test pipeline will cover this.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-53628] Upgrade pmd and spotbugs and enable checking on Java 25 [SPARK-53628] Upgrade PMD/SpotBugs and enable checking on Java 25 Sep 17, 2025
<exclude name="TooManyStaticImports" />
<exclude name="UseExplicitTypes" />
<exclude name="UseUnderscoresInNumericLiterals" />
<exclude name="TypeParameterNamingConventions" />
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is a new rule, it doesn't fit our usage. For example, we use word for parameter names but this rule enforces to use a single letter. It doesn't improve the code readability in our case.

* @param <S> The type of the state.
* @param <AS> The type of the attempt summary.
* @param <STATE> The type of the state.
* @param <SPEC> The type of the spec.
* @param <STATUS> The type of the status.
*/
public class BaseResource<
S,
AS extends BaseAttemptSummary,
STATE extends BaseState<S>,
SPEC extends BaseSpec,
STATUS extends BaseStatus<S, STATE, AS>>

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya . Merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants