[SPARK-53703] Improve unit tests to be neutral from Spark versions #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
commented
Sep 24, 2025
| "spark.kubernetes.driver.limit.cores": "5", | ||
| "spark.kubernetes.authenticate.driver.serviceAccountName": "spark", | ||
| "spark.kubernetes.container.image": "apache/spark:4.0.0" | ||
| }, |
Member
Author
There was a problem hiding this comment.
This test resource is used for Driver Service Ingress test case. So, the removed information are irrelevant and not required.
Member
Author
|
Since this is a simple test case improvement, I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve unit tests to be neutral from Spark versions.
Why are the changes needed?
It's important to become robust for (1) the future development and (2) the downstream fork's version changes.
Does this PR introduce any user-facing change?
No. This is a test-only change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.