[SPARK-53872] Revisit JUnit assert usage in test cases
#384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to revisit
JUnitassertion usage in test cases after upgrading toJUnit 6.JUnitto 6.0.0 #383Why are the changes needed?
There are three cases:
assertEquals: The first parameter is the expected value.assertNullis better thanassertEquals(null, *).assertInstanceOfis more intuitive thanassertTrue(... instanceof ...).Does this PR introduce any user-facing change?
No. This is a test case fix and improvement.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.