Commit ef37f9a
### What changes were proposed in this pull request?
This was missed when the default value of configuration is changed via the following.
- #38306
KafkaMicroBatchSourceSuite consists of set of different suites, where KafkaMicroBatchSourceSuiteBase based suite is defined. There are 4 implementations of this abstract class for now:
1. `KafkaMicroBatchV1SourceSuite` - V1 source that supposes to use `KafkaOffsetReaderConsumer` as `KafkaOffsetReader`.
2. `KafkaMicroBatchV2SourceSuite` - V2 source that supposes to use `KafkaOffsetReaderConsumer` as `KafkaOffsetReader`.
3. `KafkaMicroBatchV1SourceWithAdminSuite` - V1 source that uses `KafkaOffsetReaderAdmin` as `KafkaOffsetReader`.
4. `KafkaMicroBatchV2SourceWithAdminSuite` - V2 source that uses `KafkaOffsetReaderAdmin` as `KafkaOffsetReader`.
But `KafkaMicroBatchV1SourceSuite` and `KafkaMicroBatchV2SourceSuite` are still running based on `KafkaOffsetReaderAdmin`, as `USE_DEPRECATED_KAFKA_OFFSET_FETCHING` is `false` be default. By switching it to `true` in `beforeAll`, we make sure that corresponding `KafkaOffsetReader` is in use.
### Why are the changes needed?
To improve unit tests coverage for `KafkaOffsetReaderConsumer`
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit Tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #49164 from ostronaut/hotifx/KafkaMicroBatchSourceSuite-cover-KafkaOffsetReaderConsumer.
Authored-by: Dima <[email protected]>
Signed-off-by: Jungtaek Lim <[email protected]>
1 parent a6f82c6 commit ef37f9a
File tree
1 file changed
+31
-17
lines changed- connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010
1 file changed
+31
-17
lines changedLines changed: 31 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1591 | 1591 | | |
1592 | 1592 | | |
1593 | 1593 | | |
1594 | | - | |
1595 | | - | |
1596 | | - | |
1597 | | - | |
1598 | | - | |
1599 | | - | |
1600 | | - | |
1601 | | - | |
1602 | | - | |
1603 | | - | |
1604 | | - | |
1605 | | - | |
1606 | | - | |
1607 | | - | |
1608 | | - | |
1609 | | - | |
| 1594 | + | |
1610 | 1595 | | |
1611 | 1596 | | |
1612 | 1597 | | |
| |||
1637 | 1622 | | |
1638 | 1623 | | |
1639 | 1624 | | |
1640 | | - | |
| 1625 | + | |
1641 | 1626 | | |
1642 | 1627 | | |
1643 | 1628 | | |
| |||
1870 | 1855 | | |
1871 | 1856 | | |
1872 | 1857 | | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
| 1869 | + | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
| 1885 | + | |
| 1886 | + | |
1873 | 1887 | | |
1874 | 1888 | | |
1875 | 1889 | | |
| |||
0 commit comments