[SPARK-53812][SDP] Refactor DefineDataset and DefineFlow protos to group related properties and future-proof #52532
+357
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCHJonathan
reviewed
Oct 7, 2025
| optional SourceCodeLocation source_code_location = 6; | ||
|
|
||
| oneof details { | ||
| WriteRelationFlowDetails relation_flow_details = 7; |
There was a problem hiding this comment.
open to discussion, wdyt we define a ImplicitFlowDetails that only has relation, and StandaloneFlowDetails that has flow_name, relation and potential optional bool once in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DefineFlow, pulls out therelationproperty into its own sub-message.Why are the changes needed?
The DefineDataset and DefineFlow Spark Connect protos are moshpits of properties that could be refactored into a more coherent structure:
DefineDataset, there are a set of properties that are only relevant to tables (not views). They can beDefineFlow, the relation property refers to flows that write the results of a relation to a target table. In the future, we may want to introduce additional flows types that mutate the target table in different ways.Does this PR introduce any user-facing change?
No, these protos haven't been shipped yet.
How was this patch tested?
Updated existing tests.
Was this patch authored or co-authored using generative AI tooling?