[SPARK-54905][SQL] Simplify foreachWithSubqueries implementation in QueryPlan #53681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Sub-task SPARK-54905 === This comment was automatically generated by GitHub Actions |
Contributor
Author
heyihong
force-pushed
the
SPARK-54905
branch
2 times, most recently
from
8c18ce2 to
3e962d1
Compare
heyihong
changed the title
cloud-fan
reviewed
Jan 5, 2026
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
Outdated
Show resolved
Hide resolved
heyihong
force-pushed
the
SPARK-54905
branch
2 times, most recently
from
5b45be0 to
d17748c
Compare
heyihong
changed the title
heyihong
force-pushed
the
SPARK-54905
branch
3 times, most recently
from
10f10da to
b94fa1a
Compare
Contributor
Author
|
Discussed with @cloud-fan offline, while the current convention is to let TreeNode methods to handle plan traversal logic (including withPruning), for |
cloud-fan
approved these changes
Jan 7, 2026
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR simplifies the foreachWithSubqueries method in QueryPlan.scala by:
Why are the changes needed?
The original implementation was unnecessarily complex, using foreach to traverse children implicitly while recursively calling foreachWithSubqueries for subqueries. The new implementation is simpler and more straightforward.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests for query plan traversal should cover this change.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor 2.2.44